Skip to content
This repository has been archived by the owner on Mar 24, 2022. It is now read-only.

Eliminate sscanf usage in Archivers #5

Open
soakbot opened this issue Dec 29, 2015 · 0 comments
Open

Eliminate sscanf usage in Archivers #5

soakbot opened this issue Dec 29, 2015 · 0 comments

Comments

@soakbot
Copy link

soakbot commented Dec 29, 2015

Teknomancer
Reason: sscanf offers no real error detection and we can fail pretty badly if the input isn't as we expect. Which will happen from time to time if the workers change their outputs.

The sscanf() should be replaced with a more controlled string parsing functionality. We could also make use of BCommandPipe's ReadLine functionality in a the generic code and call into the Archiver which will maintain positional knowledge on subsequent lines.

Excuse: I wrote all of this while I was young and stupid. Now I'm just stupid.

Rainy day task again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant