Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid string duplication in catkeys #10

Open
humdingerb opened this issue Dec 17, 2023 · 3 comments
Open

Avoid string duplication in catkeys #10

humdingerb opened this issue Dec 17, 2023 · 3 comments

Comments

@humdingerb
Copy link
Member

Since I added a way to show the About/Help from the preference panel as well, additionally to from the Deskbar replicant, the strings there are doubled: once in the en.catkeys under src/locales and once in preflet/locales.

The only way I see is to not show the About/Help from the preflet and replicant, but from the devicefilter and just send it a message over the port to trigger it.
I'm a bit reluctant to put more non-mission critical stuff in there, however...

Or can we live with the translators having to copy&paste the help text?
Thoughts, @OscarL , old coding buddy? :)

@pulkomandy
Copy link
Member

pulkomandy commented Dec 17, 2023 via email

@humdingerb
Copy link
Member Author

I'm not sure I'm prepared to try delving this deep into the locale hole for one duplicated string.
If worse comes to worse, I'd rather manually (or scriptically) remove the string from one catkeys file and later copy it back from the translated catkeys...

Thanks for the suggestion, though.

@OscarL
Copy link
Contributor

OscarL commented Dec 19, 2023

@humdingerb: I can't offer any thoughts, as I have zero experience using any of the "i8n" APIs :-/

Knowing me... I'll probably try to hack something in the makefile, use only one locale dir (+ a symlink where needed), or something just as silly :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants