-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle deleted directories #30
Comments
So what "should" it do? Recreate the missing folder and then try to save there, or switch to "Save As..." mode when an attempt to save is made of an open file but it's directory is now missing? I would assume we've want the second option. |
The second option should be fine |
fixed issue #30 (handle deleted directories)
Should be fixed now, merged #36, please test. |
Seems to work. |
Now that I used this feature I would prefer Pe to recreate the missing folder and then try to save there. |
so then the test case becomes: echo text > folder/file.c I think it's safer to go to a "Save As..." condition, since there may be reasons why a folder disappeared while the file was open in Pe. Blindly recreating that folder could lead to other unforeseen issues. Opening up the "Save As..." view gives the user a chance to figure out how to solve the issue. Perhaps it was on a disk that has now been ejected. |
If folder containing a file was deleted and recreated in the background (as it often happens with haikuporter -c) Pe fails to save currently opened file. To reproduce:
echo text > folder/file.c
lpe folder/file.c &
rm -rf folder ; mkdir folder
Extremely annoying :/
The text was updated successfully, but these errors were encountered: