[DOCS] - Building the Development Image Release for VLLM #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new docs Signed-off-by: Jeff Fialho <[email protected]>
maxdebayser
reviewed
Sep 10, 2024
| ``` | ||
| - The repository for `vllm-tgis-adapter` is located at: https://github.com/opendatahub-io/vllm-tgis-adapter | ||
|
|
||
| Ensure the correct version is being installed to avoid issues during the build process. |
There was a problem hiding this comment.
What is the process to determine the correct version? Is it always the latest? Out in the case of a custom branch of tgis-adapter with extra PRS, what is the process?
| ``` | ||
| **Tip:** We will use this commit hash in changelog documentation. | ||
|
|
||
| ### 5. **Fetch the PR from Upstream** |
There was a problem hiding this comment.
What is the process to select the PRs to merge into our release?
maxdebayser
reviewed
Sep 10, 2024
Co-authored-by: Maximilien de Bayser <[email protected]> Signed-off-by: Jeff Fialho <[email protected]>
Co-authored-by: Maximilien de Bayser <[email protected]> Signed-off-by: Jeff Fialho <[email protected]>
Editing indentation loop Signed-off-by: Jeff Fialho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documentation aims to provide a streamlined process for building the VLLM development image release, outlining steps to integrate updates from upstream and ODH repositories, merge PRs, and trigger the image build. It ensures consistency in handling updates, PR merges, and version control, with clear instructions for verifying key components.