Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R1007 breaks use cases with multiple Subscriptions #297

Open
ben-Draeger opened this issue Jun 26, 2024 · 4 comments
Open

R1007 breaks use cases with multiple Subscriptions #297

ben-Draeger opened this issue Jun 26, 2024 · 4 comments
Labels
Comment Review Comment of some sort from somewhere sometime

Comments

@ben-Draeger
Copy link

Section Number

Section 3:8.3.2.12.1

Priority

  • Medium: Significant issue or clarification. Requires discussion, but should not lead to long debate.

Issue

Requirement R1007 ensures that a SOMDS Provider will never send two Reports (of the listed ReportTypes) with the same mdibVersion. However, to the best of my understanding, the BICEPS standard does not limit the subscriptions a Consumer can make.

Consider the following case:
A Consumer connects to a Provider using the SDC protocol and makes 2 subscriptions for the same ReportType (say: msg:EpisodicMetricReport). Now, an AbstractMetricState in the Providers Mdib changes. As far as I understand, the Provider is now required to send the same Report (the one updating the AbstractMetricState) to the Consumer twice - one for each Subscription.
However, this behaviour violates the Requirement R1007.

What is the Provider supposed to do in this case?

Proposed Change

An elegant way of solving this issue would be to adapt the Requirement R1007 to clearly state that the mdibVersion shall be strictly increasing within each subscription - this would still allow the Provider to send the same Report twice when the two Reports belong to different subscriptions.

@ben-Draeger ben-Draeger added Comment NEW A submitted comment waiting to be reviewed and dispositioned Comment Review Comment of some sort from somewhere sometime labels Jun 26, 2024
@ToddCooper ToddCooper removed the Comment NEW A submitted comment waiting to be reviewed and dispositioned label Jun 28, 2024
@ToddCooper
Copy link
Collaborator

SDPi Friday 2024.06.28 Review - Need to investigate whether or not this is a true problem and if so, what the priority and change should be. @d-gregorczyk will investigate.

@ToddCooper ToddCooper added this to the SDPi 1.4 review milestone Jun 28, 2024
@d-gregorczyk
Copy link
Collaborator

Confirm, is a minor issue. The requirement can be rephrased such that it is more concise. Proposal:

Within an MDIB sequence, a SOMDS Provider shall send msg:DescriptionModificationReport, msg:ObservedValueStream, msg:WaveformStream, msg:EpisodicAlertReport, msg:EpisodicComponentReport, msg:EpisodicContextReport, msg:EpisodicMetricReport, and msg:EpisodicOperationalStateReport messages with a strictly increasing msg:AbstractReport/@MdibVersion per subscription.

@d-gregorczyk d-gregorczyk removed their assignment Jun 28, 2024
@ToddCooper ToddCooper changed the title R1007 breaks usecases with multiple Subscriptions R1007 breaks use cases with multiple Subscriptions Jun 28, 2024
@ToddCooper
Copy link
Collaborator

SDPi Workshop #4 -

@d-gregorczyk Status of this change?

@d-gregorczyk
Copy link
Collaborator

Should be fixed in 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comment Review Comment of some sort from somewhere sometime
Projects
Status: New issues
Development

No branches or pull requests

3 participants