Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need minimal profile for failed transactions #76

Open
ElliotSilver opened this issue Jun 13, 2023 · 2 comments
Open

Need minimal profile for failed transactions #76

ElliotSilver opened this issue Jun 13, 2023 · 2 comments
Labels
discussion needing committee discussion enhancement New feature or request question Further information is requested

Comments

@ElliotSilver
Copy link

Is your feature request related to a problem? Please describe.
While attempting to create an AuditEvent for a failed transaction, a team member tried to start with the profile for the successful operation and override elements in order to create a failed operation profile. Obviously this didn't work, as what they were attempting to do was not a further constraint. We realized that in order to provide guidance to our implementers on how to audit a failed event, we could not use any of the provided profiles, and would need to create profiles from scratch duplicating much of the content of the success profiles.

The existing text of "Note a failure AuditEvent may follow this pattern, but would not be a successful outcome and should have an OperationOutcome" present in many of the success profiles, while informative provides no assistance at a technical level. "Follow[ing] this pattern" requires starting from scratch since the success profile cannot be reused in any manner.

Describe the solution you'd like
There should be parallel failure profiles for each of the success profiles. Or, alternatively, a sufficiently generic failure profile to cover failure cases for each of the provided success profiles.

Describe alternatives you've considered
We could author our own failure profiles within our own IG, however IHE is in a better position to provide a common, validated approach.

Additional context
N/A.

@JohnMoehrke
Copy link
Contributor

Could you attempt to make these failure profiles? That might inform us just how different they might be. I expect the failures will follow a given pattern, that once you discovered this pattern we could put that pattern into BALP. I could see one pattern that simply removes the 'success' requirement, or there might be some requirement to record the operationOutcome on 'failure', or something different. I hope that we don't have a complete replication of profiles. Your experience will be very helpful.

@JohnMoehrke JohnMoehrke added enhancement New feature or request discussion needing committee discussion labels Jun 14, 2023
@JohnMoehrke JohnMoehrke added the question Further information is requested label Jul 5, 2023
@JohnMoehrke
Copy link
Contributor

@ElliotSilver can you provide some examples of what you are thinking?
Error cases might be errors for many different reasons. Thus all I can definitively say is that the outcome is not success. I can't indicate any agent or entity or anything else as those are reliant on well formed request, when clearly an error is because there is something wrong with the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion needing committee discussion enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants