Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe #309: Grouping Annotations into Collections #130

Open
glenrobson opened this issue Nov 14, 2024 · 6 comments
Open

Recipe #309: Grouping Annotations into Collections #130

glenrobson opened this issue Nov 14, 2024 · 6 comments
Assignees
Labels
Milestone

Comments

@glenrobson
Copy link
Member

Links

Background and Summary

This recipe introduces annotation collections and shows how it is possible to layer AnnotationPages so that a viewer can bring together groups of annotations on different canvases. The example given is a set of Newspaper layout annotations which could be coloured or grouped seperatly to the OCR annotations.

Voting and changes

We welcome comments on the recipe and as well as voting +1, confused face or -1 feel free to add comments to this issue. If this issue is approved then the author will take account of the comments before we merge the branch in to the master cookbook branch.

If the recipe is rejected by the TRC then we will make the changes requested and resubmit it to a future TRC meeting. If you feel that your comments are substantial enough that the recipe should be looked at again by the TRC after the changes have been made please vote -1 (thumbs down). A confused face is treated as abstaining.

Changes to the recipe will only be made after the TRC voting process has concluded.

@triplingual
Copy link

  1. Berliner Tageblatt in the Example section should be styled Berliner Tageblatt since it's a title
  2. Somewhere in the Implementation notes it should say that a viewer is under no obligation to style the annotations in the collection in any particular way, whether as a collection or differently as each Annotation Page in the collection or as different in any way from Annotations that might be inline in a Manifest. This suggestion is engendered by the use case talking about styling annotations distinctively, but styling is completely dependent on viewer choices.

@glenrobson
Copy link
Member Author

Note a related question on the partOf being a array or object is raised here: IIIF/api#2322

@regisrob
Copy link
Member

regisrob commented Dec 2, 2024

Just a note on formatting: that are referenced in the manifest -> that are referenced in the Manifest (like all other occurrences of this word in the text)

@azaroth42
Copy link
Member

:/ for two reasons:

  1. We should figure out the array vs object answer
  2. With multiple references to the same AnnotationCollection, it seems like best practice would probably be to have a separate representation that is referenced rather than embedded

It's not wrong, but is it the pattern we want to promote at this stage?

@glenrobson
Copy link
Member Author

The benefit of embedding the collection is that the viewer can show the annotationPages grouped by collection with a label without having to retrieve the collection to get the label. It would only be one trip for this example but if you had multiple annotationcollections it could be a lot of trips.

@glenrobson
Copy link
Member Author

Issue 130 (Recipe #309: Grouping Annotations into Collections)

+1: 11 [JulieWinchester cubap danieltbrennan glenrobson ksclarke nfreire regisrob rentonsa robcast tpendragon triplingual]
0: 0 []
-1: 0 []
Not TRC: 0 []
Ineligible: 2 [LlGC-iir azaroth42]

Result: 11 / 11 = 1.00

Super majority is in favor, issue is approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants