You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this intentional? In principal I see no problem, that also other asymmetric keys could have a x5c certificate attached to it, in particular the ECKey.
Would you consider this a reasonable change?
The text was updated successfully, but these errors were encountered:
Hello and thanks for the good work on this library.
While I was using it I came across one inconsistency with respect to handling
x5c
certificates on various asymmetric keys. It looks that in principleJWTConnect-Python-CryptoJWT/src/cryptojwt/jwk/asym.py
Line 24 in 69b064b
x5c
on the key instance but only forRSAKey
s this is also included inserialize()
.JWTConnect-Python-CryptoJWT/src/cryptojwt/jwk/rsa.py
Lines 384 to 385 in 69b064b
Is this intentional? In principal I see no problem, that also other asymmetric keys could have a x5c certificate attached to it, in particular the
ECKey
.Would you consider this a reasonable change?
The text was updated successfully, but these errors were encountered: