fix(npm): do not assume error code is a string (#120)

Fixes #119
JS-DevTools · Jul 11, 2023 · 730683d · 730683d
1 parent c6846a9
commit 730683d
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 7 deletions.
diff --git a/dist/main.js b/dist/main.js
diff --git a/dist/main.js.map b/dist/main.js.map
diff --git a/src/npm/call-npm-cli.ts b/src/npm/call-npm-cli.ts
@@ -71,12 +71,15 @@ export async function callNpmCli<CommandT extends Command>(
   if (exitCode === 0) {
     successData = parseJson<SuccessData<CommandT>>(stdout);
   } else {
-    const errorPayload = parseJson<{ error?: { code?: string | null } }>(
+    const errorPayload = parseJson<{ error?: { code?: unknown } }>(
       stdout,
       stderr
     );
 
-    errorCode = errorPayload?.error?.code?.toUpperCase();
+    if (errorPayload?.error?.code) {
+      errorCode = String(errorPayload.error.code).toUpperCase();
+    }
+
     error = new errors.NpmCallError(command, exitCode, stderr);
   }
 
@@ -109,6 +112,9 @@ async function execNpm(
     npm.stdout.on("data", (data) => (stdout += data));
     npm.stderr.on("data", (data) => (stderr += data));
     npm.on("close", (code) => {
+      logger?.debug?.(`Received stdout: ${stdout}`);
+      logger?.debug?.(`Received stderr: ${stderr}`);
+
       resolve({
         stdout: stdout.trim(),
         stderr: stderr.trim(),