-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endless batching until out of memory if request to grafana loki won't hang up #56
Comments
10 seconds is the one I've seen used most. Might want to add that on a later date as the default. |
🚀 Here's the PR! #147See Sweep's progress at the progress dashboard! 💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID:
b28ba7bd78 )Install Sweep Configs: Pull Request
Tip I can email you next time I complete a pull request if you set up your email here! Actions (click)
Step 1: 🔎 SearchingI found the following snippets in your repository. I will now analyze these snippets and come up with a plan. Some code snippets I think are relevant in decreasing order of relevance (click to expand). If some file is missing from here, you can mention the path in the ticket description.Lines 1 to 45 in 88399c8
Lines 1 to 311 in 88399c8
Lines 1 to 129 in 88399c8
Lines 1 to 23 in 88399c8
Lines 1 to 59 in 88399c8
I also found that you mentioned the following Pull Requests that may be helpful:The following PRs were mentioned in the issue: Step 2: ⌨️ Coding
Modify src/requests.js with contents:
Check src/requests.js with contents:
Modify src/batcher.js with contents:
Check src/batcher.js with contents:
Modify index.js with contents:
Check index.js with contents: Modify index.d.ts with contents:
Check index.d.ts with contents:
Modify README.md with contents:
Check README.md with contents: Step 3: 🔁 Code ReviewI have finished reviewing the code for completeness. I did not find errors for 🎉 Latest improvements to Sweep:
💡 To recreate the pull request edit the issue title or description. This is an automated message generated by Sweep AI. |
If the request to grafana loki get's stuck for whatever reason, winston-loki will batch the logs until we run out of memory, since we don't have any timeout on our request defined.
As a first step I created a PR to make the timeout configurable: #55
We might want to discuss if there is a sensible timeout we want to set as a default value.
Checklist
src/requests.js
! No changes made Editsrc/requests.js
✗ Editsrc/batcher.js
! No changes made Editsrc/batcher.js
✗ Editindex.js
! No changes made Editindex.js
✗ Editindex.d.ts
✓ e9bd74a Editindex.d.ts
✓ EditREADME.md
! No changes made EditREADME.md
✗ EditThe text was updated successfully, but these errors were encountered: