Skip to content

Commit

Permalink
Allow monotonic rejection GP to initialize its inducing point allocat…
Browse files Browse the repository at this point in the history
…or from config. (facebookresearch#485)

Summary:
Pull Request resolved: facebookresearch#485

Monotonic rejection GP used to completely ignore any inducing point config, now it follows other models.

Reviewed By: crasanders

Differential Revision: D67225873

fbshipit-source-id: 843d4a129e81ac8b2f3fb4b3b63e6d24bd51e3a5
  • Loading branch information
JasonKChow authored and facebook-github-bot committed Dec 16, 2024
1 parent a077874 commit 669738f
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions aepsych/models/monotonic_rejection_gp.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,9 @@ def __init__(
dim=self.dim
)

# TODO: This allocator *must* be SobolAllocator and not the set one. This
# suggests that this model doesn't actually properly use data for inducing
# points properly.
inducing_points = SobolAllocator(
bounds=torch.stack([lb, ub]), dim=self.dim
).allocate_inducing_points(num_inducing=self.inducing_size)
inducing_points = self.inducing_point_method.allocate_inducing_points(
num_inducing=self.inducing_size
)

inducing_points_aug = self._augment_with_deriv_index(inducing_points, 0)
variational_distribution = CholeskyVariationalDistribution(
Expand Down

0 comments on commit 669738f

Please sign in to comment.