Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying a file locally causes log.Fatal #56

Open
sgielen opened this issue Jun 19, 2021 · 0 comments
Open

Copying a file locally causes log.Fatal #56

sgielen opened this issue Jun 19, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@sgielen
Copy link
Collaborator

sgielen commented Jun 19, 2021

One user copied a shared file to the same location locally. E.g. rufs/talks/foo.mp4 -> talks/foo.mp4.

The next time a readdir for the talks/ directory occurs, this causes a conflict, which is resolved by hashing both instances of the file at that location. If, at that time, the copy is not done, the hash will differ. This causes a log.Fatalf crash on the client performing the copy, so the copy is not completed and fails with "Transport endpoint is not connected".

Since this is a likely use-case, we should improve our support for it.

Note that it can be worked-around by copying to a temporary name, then moving to the correct name. Rsync automatically does this, so a work-around is to copy using rsync instead of cp.

@sgielen sgielen assigned sgielen and unassigned sgielen Jun 19, 2021
@Jille Jille added the bug Something isn't working label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants