Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local IPs to autodetected endpoints for a client #94

Open
sgielen opened this issue Jun 7, 2022 · 0 comments
Open

Add local IPs to autodetected endpoints for a client #94

sgielen opened this issue Jun 7, 2022 · 0 comments

Comments

@sgielen
Copy link
Collaborator

sgielen commented Jun 7, 2022

My laptop and PC are within the same subnet. By default, if I don't pass any endpoints, their auto-detected endpoints are only their public IPs as received from our fake STUN implementation. However, they can't reach each other on their public IPs.

If I add their local IPs to their list of endpoints, they can reach each other fine. As long as each client tries all endpoints until one works, as is current behavior, this should have few downsides. At most, if someone else has another machine behind the same local IP, there may be some warnings in their logs that incorrect certificates are being used.

@sgielen sgielen changed the title Add local IPs to possible endpoints for a client Add local IPs to autodetected endpoints for a client Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant