-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict numpy<2
and bump actions
#38
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 75.55% 75.55%
=======================================
Files 6 6
Lines 180 180
=======================================
Hits 136 136
Misses 44 44 ☔ View full report in Codecov by Sentry. |
@ablaom Restricting numpy seemed to fix the issue |
Great work and quick diagnosis! Many thanks. Is this an issue that should be fixed at PythonCall.jl (it is already tagged here) or is this "expected behaviour" and we just merge your fix (here and in all the other effected packages)? |
I did not realize that it broke PythonCall.jl. Ideally, it would be fixed there, and we could pin a minimum PythonCall.jl version. |
I am struggling to reproduce the numpy issues with just PythonCall.jl. However, I can't import catboost from the created Python environment. Our error is happening when importing catboost in Python. I have tried pip and conda installing catboost, and neither one seems to work. Python 3.12.4 | packaged by conda-forge | (main, Jun 17 2024, 10:23:07) [GCC 12.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import catboost
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/tmp/jl_mlbQrt/.CondaPkg/env/lib/python3.12/site-packages/catboost/__init__.py", line 1, in <module>
from .core import (
File "/tmp/jl_mlbQrt/.CondaPkg/env/lib/python3.12/site-packages/catboost/core.py", line 45, in <module>
from .plot_helpers import save_plot_file, try_plot_offline, OfflineMetricVisualizer
File "/tmp/jl_mlbQrt/.CondaPkg/env/lib/python3.12/site-packages/catboost/plot_helpers.py", line 5, in <module>
from . import _catboost
File "_catboost.pyx", line 1, in init _catboost
ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
>>> |
It looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for the prompt action. 🙏🏾
Ref #37
I also went ahead and bumped the actions to prevent issues down the road (since this library is less actively developed).