Print the feature names in report.print_tree() #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses issue JuliaAI#23 by modifying TreePrinter struct and fit function to include the feature_names parameter.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #54 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 1 1
Lines 141 141
=======================================
Hits 138 138
Misses 3 3 ☔ View full report in Codecov by Sentry. |
ablaom
reviewed
Feb 21, 2024
There was a problem hiding this comment.
Good to go. Thank you @adarshpalaskar1 for this contribution.
Merged
Thank you for helping me find this issue. Do we have any issues to solve with respect to TreePlots.jl integration discussed earlier / anything else I can take a stab at? |
|
@adarshpalaskar1 You could have a go at this. A bit harder. |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses issue #23 by modifying TreePrinter struct and fit function to include the feature_names parameter.