Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more fields to type Star #20

Open
elehcim opened this issue Oct 27, 2021 · 4 comments
Open

Add more fields to type Star #20

elehcim opened this issue Oct 27, 2021 · 4 comments
Labels
discussion enhancement New feature or request

Comments

@elehcim
Copy link
Contributor

elehcim commented Oct 27, 2021

Temperature, Energy.

And for star particles: age, chemical composition (metallicity).

@islent islent added enhancement New feature or request discussion labels Oct 28, 2021
@islent
Copy link
Member

islent commented Oct 28, 2021

I'm implementing a pure N-body gravity solver using PhysicalParticles.jl, so that even SPH info is redundant for now. SPH info is supported to suitably load Gadget2 snapshot files.

However, in the future (maybe distant future, since we are a small team), I have plans for MHD, numerical GR and cosmological simulations. In that case, many other fields are needed (for example, electric charge), and subgrid physics are supported and well-designed.

In brief, temperature, (total) energy, age, chemical composition (metallicity) will be supported very soon. However, this could never be an end before an adaptive and scalable subphysics data structure. (Need discussion! @longqian95 ).

@elehcim
Copy link
Contributor Author

elehcim commented Oct 28, 2021

Thanks for the reply. I'll send you an email with my intentions.

@islent
Copy link
Member

islent commented Oct 28, 2021

mry###1234@###mail.ustc###.edu.cn (# to be removed)
Welcome!

@elehcim
Copy link
Contributor Author

elehcim commented Oct 29, 2021

Ok, for now the plan is to create a Gadget2Particle<:AbstractParticle3D in AstroIO to contain the fields needed by Gadget2 files.

I'll work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants