Make it explicit that we require 1-based indexing #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In places where we say that some collection is indexable make it explicit that we assume 1-based indexing. The reason is that downstream packages assume this so I think it is better to document it.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
=======================================
Coverage 94.46% 94.46%
=======================================
Files 7 7
Lines 723 723
=======================================
Hits 683 683
Misses 40 40
☔ View full report in Codecov by Sentry. |
|
Does it make sense to use |
|
@quinnj - OK to merge? |
quinnj
approved these changes
Sep 17, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In places where we say that some collection is indexable make it explicit that we assume 1-based indexing.
The reason is that downstream packages assume this so I think it is better to document it.