Update Jupyter extension #498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2022
Merged
halleysfifthinc
force-pushed
the
webio_jupyter-updates
branch
from
f1b7cc2
to
ed377cf
Compare
halleysfifthinc
changed the title
- Updates build system to hatchling and deprecates setup.py - Bumps jupyter package compats in python and javascript
halleysfifthinc
force-pushed
the
webio_jupyter-updates
branch
9 times, most recently
from
85e5e40
to
2e23b0d
Compare
- `"importsNotUsedAsValues"` deprecated in favor of `"verbatimModuleSyntax"`
- `"paths"` definition added to silence complaints
- Recommended in
https://jupyterlab.readthedocs.io/en/latest/extension/extension_dev.html#developing-a-prebuilt-extension
- Fix imports/type-imports for newer typescript
With the notebook
```julia
using PlotlyJS, Observables
```
```julia
p = plot(scatter(;y=rand(20))
```
```julia
on(p["hover"]) do hover
@show hover
end
```
Run each cell, hover over several points to see everything working. There should be no errors in the browser console related to hover events.
Restart the kernel, and then hover over points again. There should be errors for every hover event.
halleysfifthinc
force-pushed
the
webio_jupyter-updates
branch
from
2e23b0d
to
91571b8
Compare
halleysfifthinc
commented
Nov 27, 2024
Comment on lines
+81
to
+87
| for (k,v) in IJulia.CommManager.comms | ||
| if IJulia.CommManager.comm_target(v) == :webio_comm | ||
| IJulia.CommManager.close_comm(v) | ||
| delete!(IJulia.CommManager.comms, k) | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
This doesn't actually work with Requires (not sure why), but it does work in my weakdeps branch at #516 .
Comment on lines
+233
to
+234
| // Stop attempting to handle callbacks if previous kernel is gone | ||
| this._webIO.setSendCallback((msg: any) => {}); |
There was a problem hiding this comment.
This fixes a non-user facing issue where trying to update observables after a kernel restart would throw errors in the browser console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
Summary of fixes/changes:
IJulia.CommManager.register_commmethod is not called, so WebIO never gets the messages on thewebio_commchannel.webio_commchannels in IJulia when WebIO is loaded.