Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a better solution for sum of Grads #487

Open
pvillacorta opened this issue Sep 26, 2024 · 0 comments
Open

Give a better solution for sum of Grads #487

pvillacorta opened this issue Sep 26, 2024 · 0 comments

Comments

@pvillacorta
Copy link
Collaborator

pvillacorta commented Sep 26, 2024

Now the sum of Grads is solved as follows:

+(x::Grad, y::Grad) = Grad(x.A .+ y.A, max(x.T, y.T), max(x.rise, y.rise), max(x.fall, y.fall), max(x.delay, y.delay))

But it would be nice if we could "stack" gradients:
image

Maybe this could be also extended to the rest of Sequence elements, so we could sum RF's, ADC's or even entire Sequence's in the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant