Add support for receive timeouts #217
Open
+50
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is implemented by using two tasks writing to a channel. The first task that finishes defines whether the receive call timed out or not.
|
On second thoughts, maybe it's better to have a |
|
(bump) |
|
@JamesWrigley Sorry that these PRs have languished. As I mentioned elsewhere - I am happy to give you commit access here, if that would be helpful. It would certainly help maintain the package better. |
|
Timeouts don’t generally make sense in Julia since it is already non-blocking at the Task level, so they just usually introduce complicated data races |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented by using two tasks writing to a channel. The first task that
finishes defines whether the receive call timed out or not.
Inspired by: #87 (comment).
Fixes #87.