-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1788-2015 compliance #48
Comments
In IntervalContractors, there are some functions with |
feels a little pedantic though. wouldn't it be enough to keep the functions as they are and document that the output expected by the standard is the second one? The only reason for |
I added the code to generate the ITL tests of reverse functions in ITF1788.jl. Here is an initial summary (I need to double check a few things
General:
The test suite has two "methods" for each function, one with the correct number of inputs as specified by the standard and one with one input less, which assumes that
x= [-Inf, Inf]
e.g. bothabs_rev(a, x)
andabs_rev(a) = abs_rev(a, entireinterval()
. I need to check fro the standard whether these are required or optional, but in general it does not hurt to have those? From what I can tell,sqr_rev
is the only one which has also the method with one less inputaccording to the standard, those functions should return one output. The current implementation returns multiple outputs and the "standard result" is generally the second one. Is this intentional? Should the number of outputs conform to the standard?
docstrings missing.
libieeep1788_rev.itl
power_rev
fails in 16 tests with negative exponent, the returned result is a little wider than the expected onemul_rev_IEEE1788
pow_rev.itl
powRev2
fail, due to a typo in the source code (lob
should belog
)powRev1
andpowRev2
fail, e.g.powRev1 [-infinity,-1.0] [entire] [-infinity,0.0] = [empty];
, the current Julia implementation evaluates to[0, 0]
.libieep1788_mul_rev.itl
Missing tests
atan2Rev1
andatan2Rev1
are required by the standard, but even in ITF1788 there are no tests for theseThe text was updated successfully, but these errors were encountered: