Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move definition of Domain type to DomainSetsCore.jl? #169

Open
daanhb opened this issue Nov 22, 2023 · 0 comments
Open

move definition of Domain type to DomainSetsCore.jl? #169

daanhb opened this issue Nov 22, 2023 · 0 comments

Comments

@daanhb
Copy link
Contributor

daanhb commented Nov 22, 2023

I had made a minimal implementation of DomainSetsCore.jl, a lightweight package that defines the Domain type and a domain interface. I've updated the package this week: see https://github.com/JuliaApproximation/DomainSetsCore.jl.

As things stand, I've checked that this package is compatible with IntervalSets (see master...daanhb:IntervalSets.jl:core) and with DomainSets versions 0.6 and 0.7. Moving the definition of Domain{T} seems a non-breaking change, though it would have to be coordinated so that IntervalSets and DomainSets can both be updated.

In principle, with the changes being made, IntervalSets could later go on without actually inheriting from Domain{T}. That would also require some more changes in DomainSets to ensure that such a change is seamless, so not just yet please.

Thoughts? First step would be to register DomainSetsCore.jl.

(pinging @dlfivefifty)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant