Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes to move here #15

Open
radfordneal opened this issue Oct 27, 2024 · 3 comments
Open

Bug fixes to move here #15

radfordneal opened this issue Oct 27, 2024 · 3 comments

Comments

@radfordneal
Copy link

There are a couple bug fixes in the xsum package at gitlab.com/radfordneal/xsum, which you should incorporate into this package. I'll make some other changes as well soon, however, so you might want to wait for the next tagged stable version.

@stevengj
Copy link
Member

Thanks for the heads-up!

This package is just the Julia wrapper around the API. Assuming that the API hasn't changed and we just need to re-build a newer version of the library, that actually happens by updating the build script here: https://github.com/JuliaPackaging/Yggdrasil/blob/7dd0723365f866de9f5a1c4fbe80cefa329c814f/X/xsum/build_tarballs.jl

@radfordneal
Copy link
Author

I've now tagged stable-version-3 at gitlab.com/radfordneal/xsum, which has this fix, as well as a fuzzer due to Kevin Gibbons and other additional tests, plus some speed improvements. There's also a new function for finding the exactly rounded result of dividing a superaccumulator by an integer (useful, for example, to compute the exactly-rounded mean of a set of numbers). The API is unchanged except for the addition of the new division functions.

@stevengj
Copy link
Member

stevengj commented Nov 15, 2024

I've pushed JuliaPackaging/Yggdrasil#9787 to build the new version. Once that is merged and the resulting binary package is released, I can update this package to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants