-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfixes, updates to remove warnings, & unit test improvements #39
Conversation
- AbstractSampleBuf, SampleBuf, etc. seem to have been copy/pasted from SampledSignals - changed local variables from nframes to nframe and from nchannels to nchannel to avoid issues with exported function names
tests still fail, any chance to make them work in this PR? we could tag a release if that's the case... |
Looking into it, seems to be an issue with alsa_plugins_jll |
even if you can't make the tests pass this is still fantastic progress!!! But to release a new version we probably would need passing tests. |
Yeah no worries, I'm trying to figure out the alsa_plugins_jll issue, but I'm not familiar with Binary Builder, so it's slow |
Ok I figured that wouldn't work, may need to wait for a PortAudio fix: JuliaAudio/PortAudio.jl#125 Alternatively, I can revert to |
I'll ask PortAudio devs to merge your PR. (In the meantime, please update that PR's description and bump project.toml version?) |
I don't think I should be the one deciding on a version bump for a package I'm not familiar with? |
does not seem like the alsa_plugins_jll issue will be solved anytime soon
This reverts commit 3ea4888.
@Datseris should be all set. I had to revert to using |
@Datseris does this need anything else or are you just busy? |
Sorry, I was just busy, thanks for fixing this. I'll tag a new release now! |
Thank you! |
Well, thank YOU For fixing this ! |
No problem, just wish I had seen #10 earlier! Also fyi, there are 2 CompatHelper PRs that can be closed, and maybe re-enable the CompatHelper workflow? |
I closed the PRs and registerer 2.0 in the general registry. Do you mind doing a PR that updates all the github workflows? |
Yep, no problem |
No description provided.