Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes, updates to remove warnings, & unit test improvements #39

Merged
merged 19 commits into from
Apr 29, 2024

Conversation

gnadt
Copy link
Contributor

@gnadt gnadt commented Apr 14, 2024

No description provided.

@Datseris
Copy link
Member

tests still fail, any chance to make them work in this PR? we could tag a release if that's the case...

@gnadt
Copy link
Contributor Author

gnadt commented Apr 16, 2024

Looking into it, seems to be an issue with alsa_plugins_jll

@Datseris
Copy link
Member

even if you can't make the tests pass this is still fantastic progress!!!

But to release a new version we probably would need passing tests.

@gnadt
Copy link
Contributor Author

gnadt commented Apr 16, 2024

Yeah no worries, I'm trying to figure out the alsa_plugins_jll issue, but I'm not familiar with Binary Builder, so it's slow

@gnadt
Copy link
Contributor Author

gnadt commented Apr 16, 2024

Ok I figured that wouldn't work, may need to wait for a PortAudio fix: JuliaAudio/PortAudio.jl#125

Alternatively, I can revert to @eval import PortAudio, but that's just avoiding issue instead of resolving

@Datseris
Copy link
Member

I'll ask PortAudio devs to merge your PR. (In the meantime, please update that PR's description and bump project.toml version?)

@gnadt
Copy link
Contributor Author

gnadt commented Apr 17, 2024

I don't think I should be the one deciding on a version bump for a package I'm not familiar with?

@gnadt
Copy link
Contributor Author

gnadt commented Apr 20, 2024

@Datseris should be all set. I had to revert to using @eval import PortAudio like before because I don't think the issues in other packages causing it to fail on ubuntu-latest will be fixed anytime soon (or ever). Fixed a bunch of bugs so at least the readme examples all work now (in addition to the tests).

@gnadt
Copy link
Contributor Author

gnadt commented Apr 28, 2024

@Datseris does this need anything else or are you just busy?

@Datseris
Copy link
Member

Sorry, I was just busy, thanks for fixing this. I'll tag a new release now!

@Datseris Datseris merged commit 0403faa into JuliaMusic:master Apr 29, 2024
3 checks passed
@gnadt
Copy link
Contributor Author

gnadt commented Apr 29, 2024

Thank you!

@Datseris
Copy link
Member

Well, thank YOU For fixing this !

@gnadt
Copy link
Contributor Author

gnadt commented Apr 29, 2024

No problem, just wish I had seen #10 earlier! Also fyi, there are 2 CompatHelper PRs that can be closed, and maybe re-enable the CompatHelper workflow?

@Datseris
Copy link
Member

I closed the PRs and registerer 2.0 in the general registry. Do you mind doing a PR that updates all the github workflows?

@gnadt
Copy link
Contributor Author

gnadt commented Apr 29, 2024

Yep, no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants