Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort out PROBE #371

Draft
wants to merge 83 commits into
base: main
Choose a base branch
from
Draft

Sort out PROBE #371

wants to merge 83 commits into from

Conversation

pat-alt
Copy link
Member

@pat-alt pat-alt commented Dec 8, 2023 •
edited
Loading

Let's revisit the PROBE paper and double-check if the hinge-loss function is correctly defined. For consistency, I also think invalidation rate should not be a separate convergence criterium but handled through generator conditions.

  • double-check PROBE loss function
  • invalidation rate as generator condition

(will add more details)

pat-alt and others added 30 commits November 8, 2023 10:47
@pat-alt
done for feature generator
d1a3f2c
@pat-alt
formatting
5a20ed2
@RaunoArike
Simplify methods
f1b9f44
@RaunoArike
Move the variance kwarg
1dc1876
@RaunoArike
Small fixes
961f2fe
@RaunoArike
Merge branch 'main' into 358-simplify-the-core-strct
1678158
@RaunoArike
Move files out of generate_counterfactual
2c3ca7d
@RaunoArike
Merge branch '358-simplify-the-core-strct' of https://github.com/Juli…
906fcce 
…aTrustworthyAI/CounterfactualExplanations.jl into 358-simplify-the-core-strct
@RaunoArike
Add further improvements
abe3fb0
@RaunoArike
Small fixes
7299479
@RaunoArike
Merge branch 'main' into 343-overload-the-update-method-preferred-if-…
d6dcc90 
…feasible
@RaunoArike
Minor fixes
463b7d7
@RaunoArike
Small fixes
4fbf2c8
@RaunoArike
Create structs for convergence types
3cd5ae4
@RaunoArike
Fix formatting
e516cc6
@RaunoArike
Minor fix
24b6e79
@RaunoArike
Merge branch 'main' into 358-simplify-the-core-strct
59400a2
@RaunoArike
Fix benchmarking of feature tweak
cef0524
@RaunoArike
Add error test for feature tweak
d069ffa
@RaunoArike
Rewrite convergence logic
7511d68
@RaunoArike
Small fix
6bbc668
@RaunoArike
Fix bugs
9638643
@RaunoArike @github-actions
Update src/convergence/invalidation_rate.jl
9a6684a 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@RaunoArike @github-actions
Update src/convergence/decision_threshold.jl
cf9e2c6 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@RaunoArike
Minor changes
df71519
@RaunoArike
Merge branch '358-simplify-the-core-strct' of https://github.com/Juli…
403b9a7 
…aTrustworthyAI/CounterfactualExplanations.jl into 358-simplify-the-core-strct
@RaunoArike
Merge branch 'main' into 343-overload-the-update-method-preferred-if-…
0d649e3 
…feasible
@RaunoArike
Minor fix
93184bf
@RaunoArike
Bugfix
1d798d6
@RaunoArike
Merge branch '343-overload-the-update-method-preferred-if-feasible' i…
af70576 
…nto 358-simplify-the-core-strct
pat-alt and others added 25 commits December 6, 2023 13:30
@pat-alt
tryin to errors
bd557ea
@RaunoArike @github-actions
Update test/generators/probe.jl
b77e8a8 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@RaunoArike @github-actions
Update src/generators/gradient_based/probe.jl
e6fcaa0 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@pat-alt
error with probe
14efbf0
@RaunoArike
Fix comment
1adddb7
@RaunoArike
Merge branch '358-simplify-the-core-strct' of https://github.com/Juli…
b84a381 
…aTrustworthyAI/CounterfactualExplanations.jl into 358-simplify-the-core-strct
@pat-alt
uff
db2962b
@pat-alt
returning warning in case InvalidationRateConvergence not used with P…
3ba24fb 
…robe
@pat-alt
bleh
aad6c08
@pat-alt
tryin with a try catch
36607e5
@pat-alt
trying again
a1d4066
@pat-alt
namespacing issue
cde70ae
@pat-alt
another attempt without try/catch
e7835da
@pat-alt
small fix
ba74aca
@pat-alt
hm
f1539cb
@pat-alt
uh
3c5cc82
@pat-alt
uh
6d0c869
@pat-alt
s
bb79e6d
@pat-alt
bam
4efb266
@pat-alt
come on
ab91387
@pat-alt
omg
0150597
@pat-alt
bloody hell
df3e2f2
@pat-alt
shoot me aljeblieft
f8b72de
@pat-alt
as if
ff833ee
@pat-alt
now pls
10f94dd
@pat-alt pat-alt mentioned this pull request Dec 8, 2023
Closed
@pat-alt pat-alt changed the title Continue 365 Sort out PROBE Dec 8, 2023
@VincentPikand VincentPikand mentioned this pull request Dec 11, 2023
Merged
@pat-alt pat-alt linked an issue Dec 13, 2023 that may be closed by this pull request
Sort out PROBE #376
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority 🎯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort out PROBE
2 participants
@pat-alt @RaunoArike