Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InexactError on x86 #154

Open
colinxs opened this issue Nov 30, 2019 · 1 comment
Open

InexactError on x86 #154

colinxs opened this issue Nov 30, 2019 · 1 comment

Comments

@colinxs
Copy link

colinxs commented Nov 30, 2019

Ran into this on a GitHub Actions instance with Julia 1.3.0 and x86:

 [1] throw_inexacterror(::Symbol, ::Type{Int32}, ::Int64) at ./boot.jl:560
 [2] checked_trunc_sint at ./boot.jl:582 [inlined]
 [3] toInt32 at ./boot.jl:619 [inlined]
 [4] Int32 at ./boot.jl:709 [inlined]
 [5] prune_github_value(::Int64, ::Type{Int32}) at /home/runner/.julia/packages/GitHub/oQdYa/src/utils/GitHubType.jl:74
 [6] extract_nullable(::Dict{String,Any}, ::String, ::Type{Int32}) at /home/runner/.julia/packages/GitHub/oQdYa/src/utils/GitHubType.jl:66
 [7] macro expansion at /home/runner/.julia/packages/GitHub/oQdYa/src/utils/GitHubType.jl:0 [inlined]
 [8] json2github(::Type{GitHub.Status}, ::Dict{String,Any}) at /home/runner/.julia/packages/GitHub/oQdYa/src/utils/GitHubType.jl:93
 [9] GitHub.Status(::Dict{String,Any}) at /home/runner/.julia/packages/GitHub/oQdYa/src/repositories/statuses.jl:21
Julia Version 1.3.0
Commit 46ce4d7933 (2019-11-26 06:09 UTC)
Platform Info:
  OS: Linux (i686-pc-linux-gnu)
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
  WORD_SIZE: 32
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, broadwell)
@simonbyrne
Copy link
Collaborator

Looks look like an Int32 isn’t large enough to store the status id. I actually asked GitHub about this a month ago and they said:

I believe we currently use a 4-byte integer for "id" fields you see in the REST API, so a an 8-byte integer should be enough.

That said, please be warned that this isn't publicly documented so it might change in the future. I'm not aware of any plans for it to change this, but I guess it might happen at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants