Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ICD: vkMapMemory should return a pointer aligned to the strictest alignment mentioned in the spec #8776

Open
arno-lunarg opened this issue Oct 30, 2024 · 6 comments · May be fixed by #8786
Labels
Bug Something isn't working CI/Tests Anything related to CI or testing

Comments

@arno-lunarg
Copy link
Contributor

It currently does not do that, leading to unexpected alignment issues when filling shader binding tables in the ray tracing framework

@arno-lunarg arno-lunarg added Bug Something isn't working CI/Tests Anything related to CI or testing labels Oct 30, 2024
@ziga-lunarg
Copy link
Contributor

Should this be a CTS test?

@spencer-lunarg
Copy link
Contributor

@ziga-lunarg no, this is an issue with our TestICD (the new Mock ICD) ... we have no plans to make a CTS conformance mock ICD and so a CTS test would not help

@spencer-lunarg
Copy link
Contributor

@arno-lunarg what does

aligned to the strictest alignment mentioned in the spec

mean, how would TestICD determine this, another issue is things like shaderGroupBaseAlignment we set in the profile JSON and not the ICD itself

@spencer-lunarg spencer-lunarg linked a pull request Oct 31, 2024 that will close this issue
@arno-lunarg
Copy link
Contributor Author

@arno-lunarg what does

aligned to the strictest alignment mentioned in the spec

mean, how would TestICD determine this, another issue is things like shaderGroupBaseAlignment we set in the profile JSON and not the ICD itself

No way to query that directly, so I would make sure the returned pointer is aligned to 8192, that should be enough

@spencer-lunarg
Copy link
Contributor

what did 8192 come from?

@arno-lunarg
Copy link
Contributor Author

Totally made up, just go for a somewhat big power of 2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working CI/Tests Anything related to CI or testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants