feat: KongPluginBinding API refactoring
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I prefer this schema to the existing one 🙌 |
Signed-off-by: Mattia Lavacca <[email protected]>
mlavacca
force-pushed
the
mlavacca/pluginbindings-generic-refs
branch
from
67a514c
to
bff22af
Compare
mlavacca
changed the title
KongPluginBinding API refactoring
mlavacca
force-pushed
the
mlavacca/pluginbindings-generic-refs
branch
from
bff22af
to
22bf71e
Compare
Signed-off-by: Mattia Lavacca <[email protected]>
mlavacca
force-pushed
the
mlavacca/pluginbindings-generic-refs
branch
from
22bf71e
to
c14503d
Compare
pmalek
reviewed
Aug 8, 2024
Co-authored-by: Patryk Małek <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
pmalek
reviewed
Aug 8, 2024
pmalek
reviewed
Aug 8, 2024
Co-authored-by: Patryk Małek <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
pmalek
approved these changes
Aug 8, 2024
Co-authored-by: Patryk Małek <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is a proposal to make the target references in the
KongPluginBindingresource generic.The rationale is:
KongRoute,Ingress,*RouteKongService,ServiceKongRoute, the serviceRef must be unset or aKongService. The other way around applies as well.This way we are able to reference all the K8s objects we need, and at the same time enforce the rules posed by https://docs.konghq.com/gateway/latest/key-concepts/plugins/#precedence.
Which issue this PR fixes
Fixes #7
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes