Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RaidSortOptions sort overwritten by addon defaults, re-applied every few seconds #3

Open
buzzblizard opened this issue Aug 4, 2024 · 8 comments

Comments

@buzzblizard
Copy link

My raid frame sort order swaps between RaidSortOptions and the Cell addon defaults every 3 seconds or so whilst out of combat.

@Krealle
Copy link
Owner

Krealle commented Aug 5, 2024

is this happening without any changes to the raid roster, re-specs included?

@buzzblizard
Copy link
Author

Correct. No new players joining or leaving the raid, just swapping back and forth between the default sort and RaidSortOptions

@Krealle
Copy link
Owner

Krealle commented Aug 5, 2024

I pushed a potential fix, let me know if it resolves the issue.

@buzzblizard
Copy link
Author

buzzblizard commented Aug 5, 2024

14x Cell/Utils.lua:619: invalid value (table) at index 1 in table for 'concat'
[string "=[C]"]: in function concat' [string "@Cell/Utils.lua"]:619: in function TableToString'
[string "-- More options for raid sorting

<< Further contents of RaidSortOptions.lua >>

This was during a quick LFR run.

@Krealle
Copy link
Owner

Krealle commented Aug 5, 2024

That has already been fixed 🫡

@buzzblizard
Copy link
Author

Thanks so much for reacting quickly to this!

Raid roster is now sorted, with expected updates when new raid members join or leave.

I've had the raid roster locked in the Cell default state if combat starts during the grace period before RaidSortOptions is triggered - I'm assuming this is expected and there's very little we can do about it.

@Krealle
Copy link
Owner

Krealle commented Aug 5, 2024

You can lower the grace period by setting QUE_TIMER lower, lowest possible is 0.5

@MarHuth
Copy link

MarHuth commented Aug 14, 2024

I joined a Worldboss Raid and waited in Valdrakken to see how the Addon would sort things. Most of the time the sorting was correct. I couldnt really check if people from the raid switched spec which could explain some resorting but there were times when the addon would resort every 10-45 sec without roster changes. Sometimes my player frame would be number 1 sometimes not.

[16:27:27] Hauntedmage-Ahn'Qiraj has left the raid group.
[16:27:28] [RaidSortOptions] Info: Unable to find spec info(2) for: Náirá-Blackrock[raid3], Sticious-TarrenMill[raid4], Bubbleman-Ragnaros[raid5], Skinirb-Sanguino[raid12], Gravieboom-Draenor[raid16], Spellfingers-Draenor[raid31], Brâdley-Ysondre[raid32], Berdant-Sanguino[raid33]
[16:27:56] [RaidSortOptions] Info: Unable to find spec info(2) for: Náirá-Blackrock[raid3], Sticious-TarrenMill[raid4], Bubbleman-Ragnaros[raid5], Skinirb-Sanguino[raid12], Spellfingers-Draenor[raid31], Berdant-Sanguino[raid33]
[16:28:41] [RaidSortOptions] Info: Unable to find spec info(2) for: Náirá-Blackrock[raid3], Sticious-TarrenMill[raid4], Bubbleman-Ragnaros[raid5], Skinirb-Sanguino[raid12], Berdant-Sanguino[raid33]
[16:28:58] [RaidSortOptions] Info: Unable to find spec info(2) for: Náirá-Blackrock[raid3], Sticious-TarrenMill[raid4], Bubbleman-Ragnaros[raid5], Skinirb-Sanguino[raid12], Berdant-Sanguino[raid33]
[16:29:37] [RaidSortOptions] Info: Unable to find spec info(2) for: Náirá-Blackrock[raid3], Sticious-TarrenMill[raid4], Bubbleman-Ragnaros[raid5], Skinirb-Sanguino[raid12], Berdant-Sanguino[raid33]
[16:29:42] Todesrasen-Frostwolf has left the raid group.
[16:29:43] [RaidSortOptions] Info: Unable to find spec info(2) for: Náirá-Blackrock[raid3], Sticious-TarrenMill[raid4], Bubbleman-Ragnaros[raid5], Skinirb-Sanguino[raid12], Berdant-Sanguino[raid32]

this was the Info output in the chat and this is my Sorting_order:
local SORTING_ORDER = {
"PLAYER",
--"SPECROLE",
--"SPEC",
--"NAME",
"ROLE"
}
Pretty sure that sometimes the addon defaults get re-applied because when i switched my current role around in the addon config that would switch where my Frame would end up if it is not the first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants