Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add by spell name #106

Open
kalbert312 opened this issue Oct 5, 2024 · 1 comment
Open

[Feature] Add by spell name #106

kalbert312 opened this issue Oct 5, 2024 · 1 comment
Assignees
Labels
feature New feature or request

Comments

@kalbert312
Copy link
Contributor

Describe the feature

Adding spells by name to white/blacklist instead of ID will save headache of getting all spell IDs.

Describe the implementation

Enter a spell name, then the addon loops across all spell ids that match the name and adds the spell ids to the list.

@kalbert312 kalbert312 added the feature New feature or request label Oct 5, 2024
@github-project-automation github-project-automation bot moved this to To Triage in Cell_UnitFrames Oct 5, 2024
@Krealle
Copy link
Owner

Krealle commented Oct 6, 2024

There is no direct API for getting spellIds from names (outside of player spells), so this would require iterating every single spellId in the game to find matches.
Not too keen on this just yet, but might reconsider in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: To Triage
Development

No branches or pull requests

2 participants