Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Dismiss possibility for Totems & Earth Elemental #154

Open
zwoshos opened this issue Oct 27, 2024 · 1 comment
Open

[Feature] Dismiss possibility for Totems & Earth Elemental #154

zwoshos opened this issue Oct 27, 2024 · 1 comment
Assignees
Labels
feature New feature or request

Comments

@zwoshos
Copy link

zwoshos commented Oct 27, 2024

Describe the feature

There is actually no option to dismiss totems or earth elemental with right click - like in default wow interface. We need that for like skips ...

Describe the implementation

Right click on icon.

@zwoshos zwoshos added the feature New feature or request label Oct 27, 2024
@github-project-automation github-project-automation bot moved this to To Triage in Cell_UnitFrames Oct 27, 2024
@Krealle
Copy link
Owner

Krealle commented Oct 29, 2024

This isn't currently implemented due to technical limitations.

To dismiss a Totem via clicking on the frame, you need to perform a "Secure" action, which requires making the frame itself "Secure".
This can be achieved rather easily, but whenever you make a frame "Secure", you get limited in what you are allowed to do to the frame whilst in combat as it becomes "Protected".

Due to me using Cell as a framework of sorts, I'm utilizing frames that aren't designed to be used in a protected way. And as such you would need to do some "dirty" implementations to get this to work without tainting.

I did play around with it and the only way to make it work was to essentially always have the frames shown in combat and then reducing the alpha to 0 as a way to hide them safely.
This however means that they will still eat mouseover, eg. not be clickthrough, and you would then have invisible frames that would block everything behind it.
I decided that this was very unintuitive behaviour and shipped without this option.

If there is a want for this feature, with said caveat I could re-implement it, but ideally I'd have to see if there were any better solutions, which isn't high priority right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants