Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't enable google benchmark in corona build script. #1769

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Don't enable google benchmark in corona build script. #1769

merged 1 commit into from
Nov 14, 2024

Conversation

rhornung67
Copy link
Member

Summary

  • This PR removes the line that enables benchmarks in the corona SYCL build script. The dpcpp compiler does not support C++ standards less than 17 and the version of google mark that comes with BLT does not support C++17.
  • Support for C++17 in google benchmark was added yesterday.
  • I made an issue for BLT to update, after which we can re-enable. Update Google Benchmark blt#709

@rhornung67
Don't enable google becnhmark in corona build script.
9ee40f7 
The dpcpp compiler does not support C++ standards less than 17
and the version of gbench that comes with BLT does not support C++17.
@rhornung67 rhornung67 merged commit 0aef7cc into develop Nov 14, 2024
32 checks passed
@rhornung67 rhornung67 deleted the task/rdhornung67/disable-googlebecnhmark branch November 14, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchen20 rchen20 rchen20 approved these changes

@MrBurmark MrBurmark Awaiting requested review from MrBurmark

@artv3 artv3 Awaiting requested review from artv3

@johnbowen42 johnbowen42 Awaiting requested review from johnbowen42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhornung67 @rchen20