Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5 #4152

Merged
merged 673 commits into from
Feb 8, 2022
Merged

v5 #4152

merged 673 commits into from
Feb 8, 2022

Conversation

tabacitu
Copy link
Member

@tabacitu tabacitu commented Feb 4, 2022

tabacitu and others added 30 commits January 11, 2022 10:44
…ctor

[Pivot Relations] Pivot Selector should not allow to re-select the same.
[4.2] make default min_rows in repeatable zero
…cy-old-values

Fix checklist dependency when field is cleared
[ci skip] [skip ci]
[ci skip] [skip ci]
[ci skip] [skip ci]
Add `relationship.entry` subfield for single HasOne/MorphOne
…ials-to-inc-subdirectory

[4.2] Clean up relationship directory - move partials to `inc` subdirectory & rename `relationship_select` and `repeatable_relation`
[ci skip] [skip ci]
…e-are-not-relationships

Subfields in repeatable should not be treated as relationships
…one-morphone-saving

Fix corner case in hasOne and morphOne saving
…o-not-use-subfields-attribute-only-for-checklist-dependency-field
tabacitu and others added 7 commits February 4, 2022 09:46
# Conflicts:
#	src/resources/views/crud/columns/table.blade.php
#	src/resources/views/crud/fields/inc/repeatable_row.blade.php
#	src/resources/views/crud/fields/relationship.blade.php
#	src/resources/views/crud/fields/relationship/entries.blade.php
#	src/resources/views/crud/fields/relationship/select.blade.php
#	src/resources/views/crud/fields/repeatable.blade.php
#	src/resources/views/crud/fields/select2_grouped.blade.php
#	src/resources/views/crud/fields/select2_multiple.blade.php
#	src/resources/views/crud/fields/select_grouped.blade.php
#	src/resources/views/crud/filters/date_range.blade.php
#	src/resources/views/crud/filters/range.blade.php
#	src/resources/views/crud/filters/select2.blade.php
#	src/resources/views/crud/filters/select2_ajax.blade.php
#	src/resources/views/crud/filters/select2_multiple.blade.php
#	src/resources/views/crud/filters/text.blade.php
@tabacitu
Copy link
Member Author

tabacitu commented Feb 4, 2022

TODO on Github:

  • what do we use as a default field & column now, for relationships, since we moved relationship to PRO? later: defaulted to select and select_multiple
  • should we move the JS and CSS to this backpack/pro repo too? or just keep it here for now, until v5? later: let's keep them in backpack/crud for now;
  • change backpack/crud's license to an open-source one (instead of Yummy aka dual-license); later: chose MIT;
  • change backpack/crud readme to highlight the open-core split;
  • MUST: move license check from backpack/crud to backpack/pro... or...
    • remove the license code entirely, in favor of the API token; the new .env variable could be BACKPACK_TOKEN_USERNAME, which is already unique and has a randomly-generated part;
    • when people purchase a backpack/pro license, they are instructed to add the BACKPACK_TOKEN_USERNAME to their .env file; this will be taken into account by the stats ping, and sent with it; then we'll be able to corroborate the website with the purchase, just like we do with the license code;
  • MUST: disable PRO features in FREE add-ons (eg. Clone, BulkClone, BulkDelete); alternatively, make them depend on Backpack/PRO too;
  • MUST: make changes in backpack/pro to files that were removed by this PR (diff or re-do this PR);
  • MUST: merge this into the 4.2 branch (by Jan 31st);
  • SHOULD: gracefully error if the dev is trying to use a pro feature but doesn't have it installed
    • operation
    • field
    • column
    • button
    • widget
  • SHOULD: move artisan commands for Chart and Chart-Controller from backpack/generators to backpack/pro
  • COULD: add backpack.base.send_usage_stats config value (defaults to true); nah, we can do that later maybe;

TODO on our website:

  • MUST: change installation docs to include "pro" package installation instructions;
  • MUST: add comparison table to docs (free vs pro features);
  • MUST: add "PRO" notice next to each pro feature in the docs (with link to comparison table);
  • MUST: ability to purchase backpack/pro on our website (add product for it);
  • MUST: give access to backpack/pro to everybody who's purchased Backpack in the past year;
  • MUST: change pricing page;
  • SHOULD: add "PRO" notice next to each pro feature in the demo;

@tabacitu
Copy link
Member Author

tabacitu commented Feb 4, 2022

This is now... ready for prime-time 🎉🎉🎉

See the the v5 issue board for details.

Currently includes:

BREAKING:

@tabacitu tabacitu mentioned this pull request Feb 4, 2022
@scrutinizer-notifier
Copy link

The inspection completed: 565 Issues, 76 Patches

@tabacitu tabacitu merged commit 9a246a5 into master Feb 8, 2022
@tabacitu
Copy link
Member Author

tabacitu commented Feb 8, 2022

OMG OMG OMG. It is DONE!!! 🎉🎉🎉

yey_cap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants