Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Laravel 5.3 Support #16

Closed
simkepal opened this issue Nov 5, 2016 · 12 comments
Closed

Laravel 5.3 Support #16

simkepal opened this issue Nov 5, 2016 · 12 comments

Comments

@simkepal
Copy link

simkepal commented Nov 5, 2016

Hey!

Will it be possible to use this package with laravel 5.3? If not I have to find another solution.

Thank you!

Best regards!

@trideout
Copy link
Collaborator

trideout commented Dec 1, 2016

Is anyone working on this?

@jaketoolson
Copy link

Is this package dead?

@simkepal
Copy link
Author

It would be great to know what is going on with this project....

@majksner
Copy link

There is already closed issue #15

But it seems nobody cares.

@drakakisgeo
Copy link

I'll make a pull request soon, it is working for me locally.

@simkepal
Copy link
Author

Ufff, that would be great! Or if you make your repo public :)

@drakakisgeo
Copy link

The reason I don't make a PR is because some tests fail. You can check the code in my fork https://github.com/drakakisgeo/iron-queue and the changes here -> https://github.com/LaravelCollective/iron-queue/compare/5.2...drakakisgeo:dev-5.3?expand=1

@majksner
Copy link

Size method using wrong code copied from SQS queue implementation:

https://github.com/LaravelCollective/iron-queue/compare/5.2...drakakisgeo:dev-5.3?expand=1#diff-3ccff2f8587d87d30ba6844ecb1141dfR296

Use this instead:

public function size($queue = null)
{
    return 0;
}

@drakakisgeo
Copy link

Replaced that @majksner , thanks!

@jaketoolson
Copy link

It would just be great if we could have some more contributors authorized to approve PR's etc to keep this going.

Iron.io and Push queues are very under-appreciated. I would hate to see this package continue to remain unmaintained.

@golonix
Copy link
Contributor

golonix commented Dec 29, 2016

It seems like original authors/maintainers ditched this package. I've decided to fork it and maintain it on my own. I've also added L5.3 support. You can find it here: https://github.com/HydrefLab/iron-queue

Feel free to use it. All contributions are most welcome :)

@trideout
Copy link
Collaborator

The L5.3 support has been merged into the new branch 5.3 and is now tagged for composer

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants