Method createPayload signature of IronQueue is different then the parent

[brseixas]

Hello, first of all thank you for the driver as it allows to usage of Iron queues easily in a laravel application. While working on a laravel 5.7 application I noticed what it seems a possible bug.

Stack

• PHP 7.2
• Laravel 5.7

issue:

• the createPayloadArray method calls the parent::createPayloadArray, and its passing the method parameters in a different order.

Current the signature in IronQueue is:

• protected function createPayloadArray($job, $data = '', $queue = null)

and the parent one is:

• protected function createPayloadArray($job, $queue, $data = '')

This results in the payload being incorrectly generated, which will make the job process fail.

Fix suggestion:

On IronQueue, the push method would be changed to:

  public function push($job, $data = '', $queue = null)
    {
        return $this->pushRaw($this->createPayload($job, $queue, $data), $queue);
    }

On IronQueue, the later method would be changed to:

   public function later($delay, $job, $data = '', $queue = null)
    {
        $delay = $this->secondsUntil($delay);

        $payload = $this->createPayload($job, $queue, $data);

        return $this->pushRaw($payload, $queue, compact('delay'));
    }

On IronQueue, the createPayloadArray method would be changed to:

protected function createPayloadArray($job, $queue, $data = '')
    {
        return array_merge(parent::createPayloadArray($job, $queue, $data), [
            'queue' => $this->getQueue($queue),
        ]);
    }

The payload is generated correctly which allows the job to be process as expected.

Once again, thanks for the good work and I hope this helps.

[trideout]

This should be resolved in the latest tagged release of the package, thank you!