Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Any game that uses a launcher causes dobby to be unseen #790

Open
EthanJamesBarron opened this issue Nov 12, 2024 · 7 comments
Labels
Bug / Issue Something isn't working Crash Work-in-Progress This issue or pull request is being worked on currently

Comments

@EthanJamesBarron
Copy link

EthanJamesBarron commented Nov 12, 2024

Describe the new feature or enhancement

Can we have some sort of toggle between MelonLoader using GetCurrentDirectory and just the game's folder? It's really irritating that I still have to be stuck on MelonLoader 0.5.7 because the game's launcher doesn't set the working directory

image

It also doesn't provide me with a way to add launch params so I cant take advantage of the basedir command line argument

@SamboyCoding
Copy link
Member

Should be fixed in 0.6.6, released today, as dobby was moved to the Dependencies folder.

@EthanJamesBarron
Copy link
Author

Should be fixed in 0.6.6, released today, as dobby was moved to the Dependencies folder.

Didn't work sadly since I tried upgrading to 0.6.6 before the issue. Looks like it's still searching in the wrong place for the dependency but I cant be sure because that's all it gives

@HerpDerpinstine
Copy link
Member

HerpDerpinstine commented Nov 13, 2024

Could try manually uninstalling MelonLoader then reinstall v0.6.6.
The Proxy should be looking in the proper locations.
https://github.com/LavaGang/MelonLoader/blob/master/MelonProxy/src/utils/files.rs#L26

@slxdy
Copy link
Contributor

slxdy commented Nov 13, 2024

Was the base dir always the working directory by default?

@SamboyCoding
Copy link
Member

OK yeah I see the issue, the managed side is (correctly) using the running executable's location as the default base dir, but the proxy uses the CWD.

@EthanJamesBarron
Copy link
Author

OK yeah I see the issue, the managed side is (correctly) using the running executable's location as the default base dir, but the proxy uses the CWD.

Will this be getting changed anytime soon then?

@HerpDerpinstine
Copy link
Member

OK yeah I see the issue, the managed side is (correctly) using the running executable's location as the default base dir, but the proxy uses the CWD.

Will this be getting changed anytime soon then?

This should hopefully be fixed in the latest alpha-development nightly of v0.6.7.

@HerpDerpinstine HerpDerpinstine added Bug / Issue Something isn't working Work-in-Progress This issue or pull request is being worked on currently Crash labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug / Issue Something isn't working Crash Work-in-Progress This issue or pull request is being worked on currently
Projects
None yet
Development

No branches or pull requests

4 participants