Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write instrumented bindings #27

Open
1 task done
samlaf opened this issue Oct 11, 2023 · 0 comments
Open
1 task done

Write instrumented bindings #27

samlaf opened this issue Oct 11, 2023 · 0 comments
Labels
good first issue Good for newcomers p3 low priority

Comments

@samlaf
Copy link
Collaborator

samlaf commented Oct 11, 2023

Is your feature request related to a problem? Please describe.
The avs node spec requires avs node software to instrument all of its json-rpc calls. We implemented this in instrumented_client.go

This is useful but we feel like it might be even more useful to have instrumentation at the function call level. Currently all different contract calls/transactions to eigenlayer core and avs contracts only increase the eth_call metric, so we

Describe the solution you'd like
After we refactor the chainIO clients #26, we could create instrumented_contract_caller/transactor/filterer pretty easily following the same pattern, but these would instrument function calls and export prometheus metrics with call/tx counts + duration of each call to each function. We could then potentially also add those as eigen_ metrics... tbd.

Tasks

Preview Give feedback
  1. 1 of 1
@samlaf samlaf added p3 low priority good first issue Good for newcomers labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers p3 low priority
Projects
None yet
Development

No branches or pull requests

1 participant