Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fixed a bug in prefixing properties #138

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

Fixed a bug in prefixing properties #138

wants to merge 2 commits into from

Conversation

breezewish
Copy link

I fixed a bug that PrefixFree works incorrectly when a CSS rule misses ';' but has a name with a property keyword (this usually happens after compressing the CSS file).

Bug reproduce:
#one{transition:all .2s linear}.transform{}#another{display:block;}
#one{transition:all .2s linear}#user-select{}#another{display:block;}

will be rendered to the followings (Firefox/Webkit/Opera):

#one{-moz-transition:all .2s linear}.-moz-transform{}#another{display:block;}
#one{-moz-transition:all .2s linear}#-moz-user-select{}#another{display:block;}

@LeaVerou
Copy link
Owner

Thanks!!
Why the pipe character too? ([;|}] is a character class with the characters ;, | and }. I think you meant [;}], right?

@breezewish
Copy link
Author

Oh...yes, just made a small mistake. My parents ask me to sleep now so I'll commit it 8 hours later and I think you wont mind of it :)

@LeaVerou
Copy link
Owner

LeaVerou commented Jan 5, 2016

Damn, I’m sorry @summerwish! I didn't get a notification you made the change and I forgot to merge ...for 3 years (embarrassed face).
If you’re willing to resolve the merge conflicts, I’m willing to merge this asap.
So sorry!

@pygy
Copy link
Contributor

pygy commented Jan 24, 2017

I wanted to rebase this and submit it as another PR (it would have preserved @breeswish's authorship) but the branch has been deleted in the mean time, and the detached head does not appear in my local tree...

@LeaVerou FYI you can now reslove conflicts from the Web UI.

@LeaVerou
Copy link
Owner

@pygy thanks, good to know! Sadly, this one is not resolvable via the Github UI, the button is not there…

@breezewish
Copy link
Author

@pygy Feel free to open a new PR with your commits :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants