Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define global version name #202

Open
wuan opened this issue Nov 25, 2022 · 1 comment
Open

Define global version name #202

wuan opened this issue Nov 25, 2022 · 1 comment
Labels
Tech Debt Technical debt, small improvements to code, libraries

Comments

@wuan
Copy link
Contributor

wuan commented Nov 25, 2022

At the moment we use the following version name pattern:

  • tags: v1.2.3
  • versionName: v1.2.3

For Android (although the versionName is a free string) a typical SemVer pattern (like 1.2.3) is used in most cases. For F-Droid this is the default, which required some workarounds when bringing Destiny to F-Droid (see https://gitlab.com/fdroid/fdroiddata/-/merge_requests/12136).

The proposal is to reduce the versionName to be a clean SemVer string like 1.2.3. We will need to fix the code generating the link to the terms and condition but on the other Side our Android versioning will be clean. It might be worth to have a look at the version scheme which is typical used on the iOS side as well.

@donpui
Copy link
Contributor

donpui commented Nov 28, 2022

We could switch with next release.

@donpui donpui added the Tech Debt Technical debt, small improvements to code, libraries label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech Debt Technical debt, small improvements to code, libraries
Projects
None yet
Development

No branches or pull requests

2 participants