Adding mermaid.js support via markdown-it. #2755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is for some sort of diagram rendering? I would rather not add that because its pretty much out of scope, and then all other frontends and apps would also have to add support for this feature. |
|
Yep. Here's some more cool ones that hedgedoc for example supports in their markdown. I think its fine if we have these markdown add-ons, as long as its understood that we won't maintain the libraries ourselves, and that any apps will have to do their own work supporting them. It could also be kind of a cool incentive / project for people to start adding these renderers to other platforms besides the web, like android / iOS. |
|
Closing as even if this were added, it adds to much bloat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: nm, this doesn't work currently because the library doesn't support ESM :
Error [ERR_REQUIRE_ESM]: require() of ES Module /home/xxx/git/lemmy-ui/node_modules/.pnpm/[email protected]/node_modules/mermaid/dist/mermaid.core.mjs not supported.