Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I could make a Polish translation but... #3

Open
ElCabanoss opened this issue Jan 21, 2024 · 11 comments
Open

I could make a Polish translation but... #3

ElCabanoss opened this issue Jan 21, 2024 · 11 comments

Comments

@ElCabanoss
Copy link
Contributor

I could make a Polish translation but I guess that Polish letters won't display in the game.
yyy

@Luigibonus
Copy link
Contributor

If you could give us a list of Polish letters, I'll see if I could implement them

@Luigibonus
Copy link
Contributor

Sorry, fat-fingerred on the close button

@ElCabanoss
Copy link
Contributor Author

ą ć Ć ę ł Ł ń ó Ó ś Ś ż Ż ź Ź

Btw, is there any deadline?

@Luigibonus
Copy link
Contributor

Nope! You can work on translations whenever you'd like.

@ElCabanoss
Copy link
Contributor Author

Alright! :D

So I shouldn't start translating until you implement the Polish letters, right?

@Luigibonus
Copy link
Contributor

I checked out the letters, they should be simple enough to add so feel free to start!

@ElCabanoss
Copy link
Contributor Author

Alr, I'll start tomorrow. I'm tired after work today.

@ElCabanoss
Copy link
Contributor Author

OK, I've finished but apparently I can't upload the file because I need push access or something.

@ElCabanoss
Copy link
Contributor Author

pl_PL.json

@Luigibonus
Copy link
Contributor

Thank you! I'll show you how you can submit the file through pull requests, it's the best method since you are able to make updates to the file in the future and re-submit them:

  1. Go to https://github.com/Level-Share-Square/SMC-translations/fork
  2. Then, in your forked repository, press the Add file button at the top and insert the pl_PL.json file
  3. In your forked repository, press Pull requests at the top-left, and then New pull request (the green button). Then press 'Create pull request'.

Just let me know if you run into any issues.

@ElCabanoss
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants