Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix transaction payment fee calculation #289

Open
failfmi opened this issue Nov 15, 2023 · 0 comments
Open

fix transaction payment fee calculation #289

failfmi opened this issue Nov 15, 2023 · 0 comments
Milestone
Phase 2 - M2 - Fi...

Comments

@failfmi
Copy link
Collaborator

failfmi commented Nov 15, 2023 •
edited
Loading

In the transaction payment module, computeFeeRaw has mismatching types - U128 and FixedU128.
The multiplication bnAdjustedWeightFee := multiplier.Mul(unadjustedWeightFee) should be saturated.
Revisit the logic and check whether an implementation of FixedU128 is needed.
You can find a reference here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Gosemble - Polkadot Runtimes
Status: 📋 Backlog
Milestone
Phase 2 - M2 - Fixes and Improvements
Development

No branches or pull requests
1 participant
@failfmi