Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Ecdsa signature verification #67

Closed
radkomih opened this issue Mar 17, 2023 · 0 comments · Fixed by #303
Closed

Implement Ecdsa signature verification #67

radkomih opened this issue Mar 17, 2023 · 0 comments · Fixed by #303
Assignees
Labels
good first issue Good for newcomers

Comments

@radkomih
Copy link
Collaborator

There is a TODO in the codebase:

let m = sp_io::hashing::blake2_256(msg.get());
match sp_io::crypto::secp256k1_ecdsa_recover_compressed(sig.as_ref(), &m) {
 	Ok(pubkey) =>
 		&sp_io::hashing::blake2_256(pubkey.as_ref()) ==
 			<dyn AsRef<[u8; 32]>>::as_ref(who),
 	_ => false,
}
@radkomih radkomih moved this from 🆕 New to 📋 Backlog in Gosemble - Polkadot Runtimes Mar 23, 2023
@radkomih radkomih added the good first issue Good for newcomers label Aug 31, 2023
@radkomih radkomih moved this from 📋 Backlog to 🆕 New in Gosemble - Polkadot Runtimes Aug 31, 2023
@radkomih radkomih moved this from 🆕 New to 📋 Backlog in Gosemble - Polkadot Runtimes Aug 31, 2023
@radkomih radkomih moved this from 📋 Backlog to 🆕 New in Gosemble - Polkadot Runtimes Nov 8, 2023
@failfmi failfmi self-assigned this Nov 22, 2023
@failfmi failfmi moved this from 🆕 New to 🏗 In progress in Gosemble - Polkadot Runtimes Nov 22, 2023
@failfmi failfmi linked a pull request Nov 24, 2023 that will close this issue
2 tasks
@failfmi failfmi moved this from 🏗 In progress to 👀 In review in Gosemble - Polkadot Runtimes Nov 24, 2023
@failfmi failfmi closed this as completed Nov 27, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Gosemble - Polkadot Runtimes Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants