Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume with names longer than 27 characters #7

Open
LinusU opened this issue Jan 19, 2015 · 6 comments
Open

Volume with names longer than 27 characters #7

LinusU opened this issue Jan 19, 2015 · 6 comments

Comments

@LinusU
Copy link
Owner

LinusU commented Jan 19, 2015

How should this be handled?

@LinusU
Copy link
Owner Author

LinusU commented Jan 19, 2015

Could be interesting to try and figure out how CFURLCreateBookmarkDataFromFile does it. It seems like they produce a different kind of alias format. Strange 😕

@iRobertas
Copy link

Hello, is there any news about this problem ? When you plan release a fix ? Could you be more specific and explain "I did a quick try and it turns out that truncating the volume name in the alias does indeed work." how can I do this by myself ?

@LinusU
Copy link
Owner Author

LinusU commented Feb 4, 2015

The volume name is stored twice in the alias and only the first occurrence have a limit of 27 characters. Writing anything into the first one and then the correct information into the second one works around the problem.

The code thats add the second occurrence is in create.js, line 118-132.

The current code is throwing at encode.js, line 40-44. Only using the 27 first characters from info.volume.name at this particular point works around the problem.

@LinusU
Copy link
Owner Author

LinusU commented Feb 4, 2015

There should however be a better solution, since CFURLCreateBookmarkDataFromFile produces aliases that works. We should figure out how they work and use that approach.

phoebejaffe added a commit to phoebejaffe/node-alias that referenced this issue Mar 27, 2020
truncate volume name, possibly foolhardy. Inspired by this: LinusU#7
@busterbogheart
Copy link

Very old ticket here, but still I am limited to 27 chars for a DMG (producing an Electron app with Forge). Is this still a limitation?

@erickzhao
Copy link

Hey @busterbogheart, we patched out this assertion locally with patch-package and the generated DMG works fine in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants