We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
I have a small optimization to suggest:
Is there any particular reason to not simplify
[line 84] p_data_fp32.add_(-group['weight_decay'] * group['lr'], p_data_fp32)
into
p_data_fp32.mul_(-group['weight_decay'] * group['lr'])
? Other lines could be simplified the same manner.
The text was updated successfully, but these errors were encountered:
Addition and multiplication are different operations. The above line 84 is equivalent to
p_data_fp32 += -weight_decay * lr
Your modification is equivalent to
p_data_fp32 *= (-weight_decay * lr)
These are very different updates
Sorry, something went wrong.
No branches or pull requests
Hi,
I have a small optimization to suggest:
Is there any particular reason to not simplify
into
?
Other lines could be simplified the same manner.
The text was updated successfully, but these errors were encountered: