You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for sharing these helpers! The shape tracing helper really filled a need for us. However, one thing I noticed... it doesn't seem to report wrappers. I think the problem is that OrchardCore processes and then clears the wrappers before firing the Displayed event that the shape tracing module hooks into.
Thanks for the details, Matt! It seems indeed that's the case. I'm not sure how to solve this, however. The Displaying event is invoked earlier, however, that's where wrappers are commonly added (like DynamicCacheShapeDisplayEvents and MediaShapes) so unless the Helpful Extensions feature depends on everything else, it won't necessarily see all the wrappers (or maybe we can get it run after everything else with Startup.Order.
Thanks for sharing these helpers! The shape tracing helper really filled a need for us. However, one thing I noticed... it doesn't seem to report wrappers. I think the problem is that OrchardCore processes and then clears the wrappers before firing the Displayed event that the shape tracing module hooks into.
Wrappers are cleared here:
https://github.com/OrchardCMS/OrchardCore/blob/1879619df4418ff175a59ba70dcb36bab89fcbb5/src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultHtmlDisplay.cs#L137
But the displayed event is fired just a bit later, here:
https://github.com/OrchardCMS/OrchardCore/blob/1879619df4418ff175a59ba70dcb36bab89fcbb5/src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultHtmlDisplay.cs#L144
Jira issue
The text was updated successfully, but these errors were encountered: