Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape tracing doesn't display wrappers (OSOE-340) #18

Open
mvarblow opened this issue Jan 16, 2021 · 1 comment
Open

Shape tracing doesn't display wrappers (OSOE-340) #18

mvarblow opened this issue Jan 16, 2021 · 1 comment
Labels

Comments

@mvarblow
Copy link

mvarblow commented Jan 16, 2021

Thanks for sharing these helpers! The shape tracing helper really filled a need for us. However, one thing I noticed... it doesn't seem to report wrappers. I think the problem is that OrchardCore processes and then clears the wrappers before firing the Displayed event that the shape tracing module hooks into.

Wrappers are cleared here:
https://github.com/OrchardCMS/OrchardCore/blob/1879619df4418ff175a59ba70dcb36bab89fcbb5/src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultHtmlDisplay.cs#L137

But the displayed event is fired just a bit later, here:
https://github.com/OrchardCMS/OrchardCore/blob/1879619df4418ff175a59ba70dcb36bab89fcbb5/src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultHtmlDisplay.cs#L144

Jira issue

@Piedone
Copy link
Member

Piedone commented Jan 17, 2021

Thanks for the details, Matt! It seems indeed that's the case. I'm not sure how to solve this, however. The Displaying event is invoked earlier, however, that's where wrappers are commonly added (like DynamicCacheShapeDisplayEvents and MediaShapes) so unless the Helpful Extensions feature depends on everything else, it won't necessarily see all the wrappers (or maybe we can get it run after everything else with Startup.Order.

@Piedone Piedone added the bug label Sep 18, 2022
@github-actions github-actions bot changed the title Shape tracing doesn't display wrappers Shape tracing doesn't display wrappers (OSOE-340) Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants