Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on relative paths (OSOE-804) #111

Closed
hishamco opened this issue Feb 10, 2024 · 4 comments
Closed

Don't rely on relative paths (OSOE-804) #111

hishamco opened this issue Feb 10, 2024 · 4 comments

Comments

@hishamco
Copy link
Contributor

hishamco commented Feb 10, 2024

I just noticed that this repo and other Lombiq repositories rely on different local repositories such as Helpful Libraries & Extensions .. etc. If this is the case we might need to use the path from cloned repositories instead of using local paths such as "Libraries" or "tests"

Jira issue

@github-actions github-actions bot changed the title Don't rely on relative paths Don't rely on relative paths (OSOE-804) Feb 10, 2024
@Piedone
Copy link
Member

Piedone commented Feb 10, 2024

You have two options to use these modules:

  • From NuGet as packages. Then, there are no paths to worry about, and all dependencies will be pulled from NuGet too.
  • From source. Then, you also have to add their dependencies in source form.

Are you looking for a combination of the two, where you use these modules from source, but their dependencies are loaded from NuGet? We won't be able to support that.

@hishamco
Copy link
Contributor Author

From NuGet as packages. Then, there are no paths to worry about, and all dependencies will be pulled from NuGet too.

Right

From source. Then, you also have to add their dependencies in source form.

Maybe I need to use git with submodules, If yes we might need to add it to README.md

@Piedone
Copy link
Member

Piedone commented Feb 11, 2024

The recommended way for submodules is using https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions, what is linked from the Readme and that has documentation on submodules.

@hishamco
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants