Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lombiq.Hosting.Tenants.Management.HideRecipesFromSetup: Should this work on the Tenants->Create Tenant page? (OSOE-586) #51

Closed
ericrrichards opened this issue Mar 7, 2023 · 2 comments
Labels
question Further information is requested

Comments

@ericrrichards
Copy link

ericrrichards commented Mar 7, 2023

I have tried to setup the Lombiq.Hosting.Tenants.Management.HideRecipesFromSetup feature to exclude the Blog, Agency, and Coming Soon setup recipes as options for creating a new tenant.

builder.HideRecipesByTagsFromSetup("blog", "agency", "comingsoon");

I expected that this would remove these recipes as options that could be selected when creating a new tenant, if I am in the root or default tenant of a multi-tenant OrchardCore application, and I go to Admin -> Configuration -> Tenants and click the Add Tenant button.
But I am still seeing those options available.
image

I looked at the source of the OrchardCore.Tenants.Controller.AdminController code, and it doesn't look like that area uses an ISetupService instance to get setup recipes, but rather it collects them with RecipeHarvesters directly. So the wrapped version that this feature provides wouldn't be used there.

How is this supposed to be used?

Jira issue

@github-actions github-actions bot changed the title Lombiq.Hosting.Tenants.Management.HideRecipesFromSetup: Should this work on the Tenants->Create Tenant page? Lombiq.Hosting.Tenants.Management.HideRecipesFromSetup: Should this work on the Tenants->Create Tenant page? (OSOE-586) Mar 7, 2023
@Piedone Piedone added the question Further information is requested label Mar 7, 2023
@Piedone
Copy link
Member

Piedone commented Mar 7, 2023

The feature only hides the selected recipes from the setup screen, not the tenant management screen.

@Piedone
Copy link
Member

Piedone commented Mar 9, 2023

From the thumbs up I suppose this answered your question, then.

@Piedone Piedone closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants