Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MaximumSpace to MaximumSpaceBytes (OSOE-658) #77

Closed
2 tasks done
Piedone opened this issue Jul 13, 2023 · 0 comments · Fixed by #79
Closed
2 tasks done

Rename MaximumSpace to MaximumSpaceBytes (OSOE-658) #77

Piedone opened this issue Jul 13, 2023 · 0 comments · Fixed by #79
Assignees
@DemeSzabolcs

Comments

@Piedone
Copy link
Member

Piedone commented Jul 13, 2023 •
edited
Loading

The config MaximumSpace doesn't convey what unit it uses. Commonly, we add a suffix for this, so let's do that now as well, and rename it to MaximumSpaceBytes.

  • Rename all instances of this identifier. This includes not just the configuration key but all internal variables, and methods as well.
  • For backward compatibility, the logic should be that first the new key is read, and if there's no value for it, then the old one (and if there's no value for that either, then use the default as we do now).

Jira issue
@github-actions github-actions bot changed the title Rename MaximumSpace to MaximumSpaceBytes Rename MaximumSpace to MaximumSpaceBytes (OSOE-658) Jul 13, 2023
@DemeSzabolcs DemeSzabolcs self-assigned this Jul 20, 2023
@github-actions github-actions bot mentioned this issue Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DemeSzabolcs DemeSzabolcs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OSOE-658: Rename MaximumSpace to MaximumSpaceBytes Lombiq/Hosting-Tenants
2 participants
@Piedone @DemeSzabolcs