Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm version dependency missing from the documentation (OSOE-827) #96

Open
dministro opened this issue Mar 3, 2024 · 2 comments
Open
Labels
documentation Improvements or additions to documentation

Comments

@dministro
Copy link
Member

dministro commented Mar 3, 2024

return process.env.npm_config_local_prefix ?? process.env.LOMBIQ_NODEJS_EXTENSIONS_PROJECT_DIRECTORY;

The npm_config_local_prefix environment variable (introduced in npm v7.22.0, changelog) is used, but this version dependency is not mentioned in the documentation.

Jira issue

@dministro dministro added the documentation Improvements or additions to documentation label Mar 3, 2024
@github-actions github-actions bot changed the title npm version dependency missing from the documentation npm version dependency missing from the documentation (OSOE-827) Mar 3, 2024
@sarahelsaig
Copy link
Member

If the above linked line is falsey, it should also throw an exception explaining the problem because people tend to not read documentations.

@Piedone
Copy link
Member

Piedone commented Oct 10, 2024

Is the core of the issue about NPM v7.22.0+ being required? Because while the minimum NPM version is not documented, the minimum Node version is (v18), which uses NPM 8.6.0. So, running anything earlier is already not supported in a documented way.

BTW npm_config_local_prefix is not something that you need to set manually, it'll be set by the NPM process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants